PHP Classes

Forking?

Recommend this page to a friend!

      Tradukoj PHP Po File Generator  >  All threads  >  Forking?  >  (Un) Subscribe thread alerts  
Subject:Forking?
Summary:Forking from another project. Is licensing compatible?
Messages:5
Author:Filip Komar
Date:2015-02-18 13:18:14
 

  1. Forking?   Reply   Report abuse  
Picture of Filip Komar Filip Komar - 2015-02-18 13:18:14
Hi there.

I'm puzzled with function readFromFile in /Classes/PoClass.php as it looks very similar to
function phpmo_parse_po_file from https://github.com/phpmo/php.mo/blob/master/php-mo.php or maybe another php-mo clone.

If that's the case I'm not sure if licensing is compatible for both. Can you please explain me?

Thanks for your contribution,
Filip.

  2. Re: Forking?   Reply   Report abuse  
Picture of Joseluis Laso Joseluis Laso - 2015-02-18 19:35:59 - In reply to message 1 from Filip Komar
Hi Filip.

I'm not sure 100% to understand your question.

I've taken a look to the two functions and it's true that I have been inspired in the work of DougHW. I've forgotten to make this mention in my code.

Please, can you explain a little bit your question?

Thank you so much.

  3. Re: Forking?   Reply   Report abuse  
Picture of Filip Komar Filip Komar - 2015-02-19 20:34:58 - In reply to message 2 from Joseluis Laso
You fix the class already. Nice.

I think if you were inspired and not reusing the code that is enough but I'm not a legal expert ;).

When testing Joss's library I found two bugs.
First is rare. Last correctly translated string is lost if there is a fuzzy comented string (#~ ).
The other is a bit specific too. His library doesn't distinguish same strings (same msgid) with different context (msgctxt).
More info on my modification:
bugs.mageia.org/show_bug.cgi?id=148 ...

  4. Re: Forking?   Reply   Report abuse  
Picture of Joseluis Laso Joseluis Laso - 2015-02-19 21:00:59 - In reply to message 3 from Filip Komar
Thank you so much Filip.

Let me that I see your changes to revise if can be applied in my case.

Regarding to the licence:
To be honest, I don't have any problem to recognize if I've been inspired or actually is a total copy. I've been revised the licence of the original package and I believe this is not a problem, but in a couple of days I'll revise deeply and I'll correct my annotations if needed.

Regarding to the package:
If you don't have inconvenient I'm facing with a problem using the original library to write the mo/po files, and for this reason, in order to launch the packages I've decided to use an exec with the external tool to generate this files.

Can I have your impressions about this subject ?

Thank you so much.

  5. Re: Forking?   Reply   Report abuse  
Picture of Filip Komar Filip Komar - 2015-02-20 20:58:22 - In reply to message 4 from Joseluis Laso
You're welcome.

I'll try to answer but you gaved a little details what was the problem.

I prefer using php ;). Well when writing the files can be done if the target directory is at least in the same group as the web server. Of course it needs to be writable as well. Same goes for the target file. Assuming you're using Linux as a OS. On others operating system details can be a bit different of course.